Skip to content

Gloas alpha spec 12 changes - #9596

Merged
mergify[bot] merged 15 commits into
sigp:unstablefrom
eserilev:alpha-spec-12
Aug 6, 2026
Merged

Gloas alpha spec 12 changes#9596
mergify[bot] merged 15 commits into
sigp:unstablefrom
eserilev:alpha-spec-12

Conversation

@eserilev

@eserilev eserilev commented Jul 8, 2026

Copy link
Copy Markdown
Member

Issue Addressed

All the changes required for gloas alpha spec 12 minus stable containers. Note that EF tests cannot pass without the stable container changes. For example finality tests fail w/ ParentBlockRootMismatch because progressive merkelization isn't implemented.

So I think the plan should be to merge progressive containers, without enabling the new alpha spec 12 tests, and then merge this PR

@eserilev eserilev added ready-for-review The code is ready for review work-in-progress PR is a work-in-progress and removed blocked ready-for-review The code is ready for review labels Aug 4, 2026

@macladson macladson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that we will need to re-enable the rest of the failing alpha 12 tests which I disabled in #9450

# TODO(alpha.12): these tests are disabled until the v1.7.0-alpha.12 EIP-8282 changes are
# implemented.
"tests/.*/gloas/fork/.*",
"tests/.*/gloas/operations/parent_execution_payload/.*",
"tests/.*/gloas/operations/builder_deposit_request/.*",
"tests/.*/gloas/operations/builder_exit_request/.*",

@eserilev eserilev added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Aug 5, 2026
@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 5, 2026
@mergify mergify Bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 5, 2026

@pawanjay176 pawanjay176 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the partial column size enforcement.

Comment thread beacon_node/lighthouse_network/src/types/pubsub.rs
@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

@chong-he chong-he left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few small comments

Comment on lines +530 to +531
#[test]
fn test_payload_withdrawals_over_limit() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are five types of execution requests and we have two tests checking the execution requests - max_withdrawals_per_payload and max_builder_exit_requests_per_payload.

I understand that the tests are repetitive and so that's probably why you didn't include a test for the other 3 types of requests. So I will leave it to you whether to add them or not.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/*
* This test ensures that:
*
* We do not accept gloas blocks whose progressive operation lists exceed their spec limits.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can be a bit more specific here? If I understand correctly this is about for Gloas, there can be no more Deposit accepted in a block. A suggestion as below, but feel free to modify as you see fit

Suggested change
* We do not accept gloas blocks whose progressive operation lists exceed their spec limits.
* We do not accept gloas blocks whose progressive operation lists exceed their spec limits (in this case, the `Deposit` should always be empty)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +94 to +95
# 2**6 (= 64) epochs
MIN_BUILDER_WITHDRAWABILITY_DELAY: 64

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the spec has this field:

https://github.com/ethereum/consensus-specs/blame/5366cb59eb39e4ec1d6c468a79cceb626c14c048/configs/mainnet.yaml#L101-L102

# 5000 basis points, 50% of SLOT_DURATION_MS
PAYLOAD_DUE_BPS: 5000

Do we need to add it here too? (also the minimal.yaml)

The same goes for the file: common/eth2_network_config/built_in_network_configs/mainnet/config.yaml

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eserilev eserilev added the ready-for-merge This PR is ready to merge. label Aug 6, 2026
@mergify mergify Bot added the queued label Aug 6, 2026
@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merge Queue Status

  • Entered queue2026-08-06 04:46 UTC · Rule: default · triggered by rule Add ready-to-merge labeled PRs to merge queue
  • 🚫 Left the queue2026-08-06 04:47 UTC · at 750400ca32dba7d6e8f32ad84dad83b4e23b3be4

This pull request spent 1 minute 10 seconds in the queue, with no time running CI.

Reason

The pull request #9596 has been manually updated

Requeued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 20 minutes 28 seconds in the queue, including 18 minutes 32 seconds running CI.

Waiting for
  • check-success=local-testnet-success
  • check-success=test-suite-success
All conditions

Reason

The merge conditions cannot be satisfied due to failing checks

  • test-suite-success

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Some required checks have failed. Could you please take a look @eserilev? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. dequeued and removed ready-for-review The code is ready for review queued labels Aug 6, 2026
@eserilev

eserilev commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

@mergify requeue

@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 28 minutes 50 seconds in the queue, including 27 minutes 23 seconds running CI.

Required conditions to merge

@mergify mergify Bot added queued and removed dequeued labels Aug 6, 2026
@mergify
mergify Bot merged commit 3c9a9b6 into sigp:unstable Aug 6, 2026
37 of 38 checks passed
@mergify mergify Bot removed the queued label Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gloas ready-for-merge This PR is ready to merge. waiting-on-author The reviewer has suggested changes and awaits thier implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants